Firefox (and maybe Edge) details.ip = null causes False Positives

[wisec]

Firefox from time to time seems to not populate details.ip and sets it to null. Chrome/Chromium, so far, has always set details.ip.

https://github.com/mindedsecurity/behave/blob/master/background.js#L481

chrome.webRequest.onResponseStarted.addListener(function (details) {
  if (shouldMonitor()) {
    const requestInfo = requestMap[details.requestId];
    if (details.tabId !== -1 && requestInfo) {
      debuglog(details, requestInfo);

      maybeRebinding(details.ip, requestInfo);
[...]

This might lead to False Positives or False Negatives on Firefox - and maybe Edge too.

[wisec]

It might be related to cached content, as I'm observing that when happens details.fromCache is true. I'll keep browsing with Firefox to see if this behavior is coherent.

Cross browser implementations, you gotta love them :sweat_smile:

[wisec]

There you go:

remote/observers/NetworkObserver.jsm:      // remoteAddress is not defined for cached requests.

Edit: or not ..

[wisec]

Fixed