mindee / tawazi

A DAG Scheduler library written in pure python

https://mindee.github.io/tawazi/

Apache License 2.0

83 stars 5 forks source link

Fix tuple typing #210

Closed bashirmindee closed 8 months ago

bashirmindee commented 8 months ago

Description

Fixes a problem of future annotations. When using the newer typing system (types are strings), the check on unpack_to doesn't work. This fixes it.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

bashirmindee commented 8 months ago

I will forward port it right now