minderlabs / demo

Minder Demo App
1 stars 0 forks source link

Universal search demo pt 1: google drive. #47

Closed adamberenzweig closed 7 years ago

adamberenzweig commented 7 years ago

Sending a bit early because I just saw you have some overlap in #46 .

Looks like we can manage it without using the old python backend at all. Added some new scope to firebase auth. The server fetches the credentials (stored during client registration) and sticks them into the request context, available to send to the Google Drive API.

Notes:

adamberenzweig commented 7 years ago

Rich, what should happen when someone clicks on a search result that corresponds to an external link (Document)? In the current design, there's no way to render a detail page, because the transient item ID doesn't exist in the store. I can link to the external URL, but that's confusing UX.

I think we've reached the limit of what we can do with generic item rendering in lists. I started tinkering w/ type-specific ListItem components. I can keep going down that road if it seems right.

richburdon commented 7 years ago

Re comments above.

1). I think the main concern is to normalize ListItem rendering and dispatch the TypeRegistry for custom fields (or column sections).

2). OK with me to merge after you've taken a look at this: https://docs.google.com/document/d/1qMwaBb8jcip1zZipvFIM5SZDDE07ZL5Lpz0UtM1dH-I/edit#