mindersec / minder

Software Supply Chain Security Platform

https://minder-docs.stacklok.dev/

Apache License 2.0

258 stars 37 forks source link

Fix diff full ingester double deref. #4732

Closed blkt closed 1 week ago

blkt commented 1 week ago

Summary

This was causing errors during evaluations of rules that cast res.Object like https://github.com/stacklok/minder/blob/main/internal/engine/eval/homoglyphs/application/homoglyphs_service.go#L84

Change Type

[X] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual tests.

Review Checklist:

[X] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[X] Checked that related changes are merged.

coveralls commented 1 week ago

coverage: 53.118% (-0.007%) from 53.125% when pulling 36c526eb3972034d31641697729ac66750177610 on fix/diff-full-ingester-double-deref into f191f5d1e5afa4f5502f09d955c8340f733c048c on main.