mindersec / minder

Software Supply Chain Security Platform

https://minder-docs.stacklok.dev/

Apache License 2.0

258 stars 37 forks source link

Re-enable NATS test #4746

Closed evankanderson closed 4 days ago

evankanderson commented 5 days ago

Summary

Fixes NATS test to pass (in 1000/1000 runs on my Macbook)

Reworked timeouts after some examination to allow the test to run much faster (0.011s vs 25s)

Change Type

Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing

go test -count 1000 ./internal/events/nats

Review Checklist:

[x] Reviewed my own code for quality and clarity.
[x] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[x] Included tests that validate the fix or feature.
[x] Checked that related changes are merged.

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 11334292499

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 53.908%

Totals
Change from base Build 11329907734:	0.5%
Covered Lines:	14768
Relevant Lines:	27395

💛 - Coveralls