mindersec / minder

Software Supply Chain Security Platform

https://minder-docs.stacklok.dev/

Apache License 2.0

258 stars 37 forks source link

Move provider class manager interfaces to a public package #4751

Open JAORMX opened 5 days ago

JAORMX commented 5 days ago

Summary

These are to be implemented by providers. Thus, they make no sense to be internal interfaces.

Change Type

Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[x] Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations. Attach screenshots if helpful.

Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

jhrozek commented 4 days ago

the unit test failures look related to the PR

JAORMX commented 4 days ago

@jhrozek they are, I gotta look into them.