mindersec / minder

Software Supply Chain Security Platform
https://minder-docs.stacklok.dev/
Apache License 2.0
294 stars 42 forks source link

Include provider ID in minder CLI response #5029

Closed navnitms closed 3 days ago

navnitms commented 3 days ago

Fixed the issue where deleting a provider by its ID was not possible due to the missing provider ID in the CLI response

Summary

Provide a brief overview of the changes and the issue being addressed. Explain the rationale and any background necessary for understanding the changes. List dependencies required by this change, if any.

Fixes #5000

Change Type

Mark the type of change your PR introduces:

Testing

Tested the flow using CLI command minder provider get -n <provider-name>

Response :

image

Review Checklist:

coveralls commented 3 days ago

Coverage Status

coverage: 54.515% (-0.005%) from 54.52% when pulling 426301a8630099f1d2ccdaeeff1a841b72a8705e on navnitms:add-provider-id-to-cli-response into c6efd48497d33ea63e5f4b8cafdab5713b3d31e0 on mindersec:main.

evankanderson commented 3 days ago

(The security scan failure is an upstream Trivy issue where they are triggering on their own examples...)