search

mindflayer / python-mocket

a socket mock framework - for all kinds of socket animals, web-clients included
BSD 3-Clause "New" or "Revised" License
284 stars 43 forks source link

Remove pipenv from `setup_requires` #121

Closed jonringer closed 4 years ago

jonringer commented 4 years ago

pipenv should not be required for sdist installations.

noticed this behavior when reviewing https://github.com/NixOS/nixpkgs/pull/95689

mindflayer commented 4 years ago

Good catch @jonringer, it was related to the first approach I used to introduce pipenv. Definitely not needed!

mindflayer commented 4 years ago

Just released, in case it's needed. https://pypi.org/project/mocket/3.8.8/

jonringer commented 4 years ago

we patched it in our end. But I just wanted upstream (you guys in this case :) ) to be aware

jonringer commented 4 years ago

I appreciate the patch bump though :)