search

mindflayer / python-mocket

a socket mock framework - for all kinds of socket animals, web-clients included
BSD 3-Clause "New" or "Revised" License
283 stars 42 forks source link

requirements.txt missing #143

Closed mweinelt closed 3 years ago

mweinelt commented 3 years ago

Describe the bug The requirements.txt referenced in setup.py is not part of the Git repo.

https://github.com/mindflayer/python-mocket/blob/343f5b913616e2c7bcc916cdd9127afa6e1cf7c6/setup.py#L11-L17

To Reproduce n/a

Expected behavior Include the requirements.txt so python setup.py install can work.

mindflayer commented 3 years ago

What is the problem you are trying to solve? In which situation you were not able to install mocket?

/tmp $ python3 -m venv .venv
/tmp $ source .venv/bin/activate.fish
(.venv) /tmp $ pip install mocket
Collecting mocket
  Downloading mocket-3.9.39.tar.gz (74 kB)
     |████████████████████████████████| 74 kB 306 kB/s 
Collecting decorator>=4.0.0
  Downloading decorator-4.4.2-py2.py3-none-any.whl (9.2 kB)
Collecting http-parser>=0.9.0
  Downloading http-parser-0.9.0.tar.gz (167 kB)
     |████████████████████████████████| 167 kB 7.7 MB/s 
Collecting python-magic>=0.4.5
  Downloading python_magic-0.4.20-py2.py3-none-any.whl (12 kB)
Collecting urllib3>=1.25.3
  Downloading urllib3-1.26.2-py2.py3-none-any.whl (136 kB)
     |████████████████████████████████| 136 kB 7.0 MB/s 
Using legacy setup.py install for mocket, since package 'wheel' is not installed.
Using legacy setup.py install for http-parser, since package 'wheel' is not installed.
Installing collected packages: decorator, http-parser, python-magic, urllib3, mocket
    Running setup.py install for http-parser ... done
    Running setup.py install for mocket ... done
Successfully installed decorator-4.4.2 http-parser-0.9.0 mocket-3.9.39 python-magic-0.4.20 urllib3-1.26.2
mindflayer commented 3 years ago

As you can see the file is part of the package: mocket

mweinelt commented 3 years ago

I'm trying to install a tag from Git, not from PyPi. This would be helpful for packaging, since then we could execute the tests during packaging, as they weren't included in the PyPi package last I checked.

❯ git clone https://github.com/mindflayer/python-mocket.git
Cloning into 'python-mocket'...
remote: Enumerating objects: 65, done.
remote: Counting objects: 100% (65/65), done.
remote: Compressing objects: 100% (58/58), done.
remote: Total 1900 (delta 31), reused 10 (delta 6), pack-reused 1835
Receiving objects: 100% (1900/1900), 420.29 KiB | 1.34 MiB/s, done.
Resolving deltas: 100% (1243/1243), done.
❯ cd python-mocket
❯ python3 -m venv .venv
❯ source .venv/bin/activate
❯ python setup.py install
Traceback (most recent call last):
  File "setup.py", line 13, in <module>
    for line in io.open(
FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'
mindflayer commented 3 years ago

Have a look at Makefile, there is everything in place to set up the project, and let me know if you need more support.

mindflayer commented 3 years ago

as they weren't included in the PyPi package last I checked

This has been fixed already. You can see it from the screenshot I posted.

September 2019: https://github.com/mindflayer/python-mocket/pull/101

mweinelt commented 3 years ago

Ah, my bad. Thanks!

mindflayer commented 3 years ago

No issue, I am glad to help!