search

mindflayer / python-mocket

a socket mock framework - for all kinds of socket animals, web-clients included
BSD 3-Clause "New" or "Revised" License
279 stars 41 forks source link

Begin mypy type-checking #229

Closed Kilo59 closed 2 months ago

Kilo59 commented 3 months ago

Begin minimal type-checking of the codebase as part of the effort to export type hints.

Will followup this up to add annotations to remaining modules.

mindflayer commented 2 months ago

I am sorry it took a while, I had to find some time to invest in the CI for being able to run tests on external PRs. It looks like mypy is not happy about the way I am dealing with location when made of just a str. I'll come back to you with a fix.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

coveralls commented 2 months ago

Coverage Status

coverage: 98.59% (-0.2%) from 98.818% when pulling f0e5442fb4512f9f476f1f8b2a4fb7663c39b4ab on Kilo59:main into 389d95e657772a37d634088d50138b1faa19bf0b on mindflayer:main.

mindflayer commented 2 months ago

Merged, we still lack a pre-commit hook for mypy.