mindgamer-net / steam-stellaris-r27-portraits

Stellaris Steam workshop mod 'R27 Animated portraits'
https://steamcommunity.com/sharedfiles/filedetails/?id=1445328980
GNU General Public License v3.0
1 stars 1 forks source link

Add more silicoid portraits from silfae #2

Open zokradonh opened 4 years ago

zokradonh commented 4 years ago

I could see that you used to have more silicoid portraits but removed one in commit c51e6db7ee6a5f4eecfd926ee9182e6a6af6b6b3. But originally there are more:

Original Silfae Thumbnail

I could make another pull request to add them or did you encounter problems with them?

mindgamer-net commented 4 years ago

I think the reason for removing the portrait at the time was that it felt just as a personal mod and I did not care too much for the aesthetics.. felt too much of a Star Trek Original Series Rubber Suit species.. but feel free to make a pull request to add them back.

I am not a fan of adding several species which are pretty much the same portrait, just with different colors, though. That should be accomplished using the color picker and not having a separate portrait for each color. I haven't checked out the original mod in a while though and perhaps the attached image is only for effect and actually there are not several colored versions of some portraits. Disregard my comment in that case.

Overall I feel Silfae's mods are all great enough to be added without much second thought.. but they are also a bit more work because they mostly involve a bit more custom race and logic code.

zokradonh commented 4 years ago

Yes, they are implemented with color choser.

And yes, I have seen some custom logic in his mods that we don't want in your mod. But I will be able to remove it.

mindgamer-net commented 4 years ago

I'd be happy to accept such a change if you feel up to it