Closed jeroenbraspenning closed 1 year ago
Hey @jeroenbraspenning
I think this is a duplicate of https://github.com/mindkomm/timmy/issues/36. Because I have to refactor quite a few things to get this right, it’s taking a little longer.
This was fixed in the first beta for Timmy 1.0.0. The most current beta version is 1.0.0-beta.3. You can test it with that version.
I stumbled across an issue with the
timmy/generate_srcset_sizes
hook. When set to true, the system will automatically generate all responsive sizes. This works perfect, but not if you have the following oversize configuration:'oversize' => array( 'allow' => false, 'style_attr' => false )
It should not generate sizes bigger than the source image, but it does. The function (generate_srcset_size, timmy.php, r864) which generates the sizes doesn't check the oversize settings. As a temporary workaround i did the following, which fixes it for now.rule 904:
Thanks for your work!