mindmelting / lex-oscarbot

7 stars 2 forks source link

Refactor dialog actions #116

Closed dwmkerr closed 7 years ago

dwmkerr commented 7 years ago

This pull request reduces duplication by removing some of the common code around dialog actions. This is step 1. For step 2, we'll remove duplication in the confirmation code and then return the old dialogActions in favour of dialog.

mindmelting commented 7 years ago

Codecov Report

Merging #116 into master will decrease coverage by 4.16%. The diff coverage is 82.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   88.71%   84.54%   -4.17%     
==========================================
  Files          46       48       +2     
  Lines         629      634       +5     
==========================================
- Hits          558      536      -22     
- Misses         71       98      +27
Impacted Files Coverage Δ
oscarbot/utils/dialog/failed.js 100% <ø> (+66.66%) :arrow_up:
oscarbot/utils/dialogActions.js 11.11% <ø> (-16.17%) :arrow_down:
oscarbot/intents/countOpenPRs.js 100% <100%> (ø) :arrow_up:
oscarbot/intents/countIssues.js 100% <100%> (ø) :arrow_up:
oscarbot/intents/whatProjectsAmIWorkingOn.js 100% <100%> (ø) :arrow_up:
oscarbot/utils/dialog/index.js 100% <100%> (ø)
oscarbot/utils/dialog/fulfilled.js 100% <100%> (ø)
oscarbot/intents/whatCanIAskYou.js 100% <100%> (ø) :arrow_up:
oscarbot/intents/myOpenIssues.js 100% <100%> (ø) :arrow_up:
oscarbot/intents/whatAreMyMostPopularProjects.js 100% <100%> (ø) :arrow_up:
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24202dc...3757020. Read the comment docs.

dwmkerr commented 7 years ago

thanks for fixing the debugger issue