search

mindmelting / lex-oscarbot

7 stars 2 forks source link

Update copy and utternaces #141

Closed mindmelting closed 7 years ago

mindmelting commented 7 years ago

Closes #106

mindmelting commented 7 years ago

Codecov Report

Merging #141 into master will decrease coverage by 0.2%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   86.47%   86.27%   -0.21%     
==========================================
  Files          57       55       -2     
  Lines         732      714      -18     
==========================================
- Hits          633      616      -17     
+ Misses         99       98       -1
Impacted Files Coverage Δ
oscarbot/index.js 93.75% <0%> (ø) :arrow_up:
oscarbot/intents/goodbye.js
oscarbot/intents/goodbye.spec.js
oscarbot/intents/openIssue.js 45.83% <0%> (+1.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7009598...122ea87. Read the comment docs.

dwmkerr commented 7 years ago

Looks good - but we are inconsistent with how we italicise project names. Should we:

  1. Always italicise project names (looks goofy in the CLI)
  2. Always use single quotes like:

    You are about to open an issue with the name 'issue name', and the details 'some details'?