search

mindmelting / lex-oscarbot

7 stars 2 forks source link

Replace JSON files in tests with object literals #148

Closed dwmkerr closed 7 years ago

dwmkerr commented 7 years ago

Removes test JSON files in favour of objects created explicitly. Makes tests easier to read and update./

mindmelting commented 7 years ago

Codecov Report

Merging #148 into master will increase coverage by 0.15%. The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   86.47%   86.63%   +0.15%     
==========================================
  Files          57       57              
  Lines         732      733       +1     
==========================================
+ Hits          633      635       +2     
+ Misses         99       98       -1
Impacted Files Coverage Δ
oscarbot/intents/tests/createTestInput.js 100% <ø> (ø) :arrow_up:
oscarbot/validateSession.spec.js 100% <100%> (ø) :arrow_up:
oscarbot/intents/openIssue.spec.js 79.16% <85.71%> (+3.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e197e31...e736011. Read the comment docs.