mindon / ingress-portals-finder

a Chrome Extension for the Game - Ingress
74 stars 59 forks source link

Today always: "Query Failed - Sign-In Required!" #30

Open kfmook opened 11 years ago

kfmook commented 11 years ago

today plugin always say (v 1.3.16 with manual patch for Enligtened, and v 1.3.17): Query Failed - Sign-In Required! If already in, try "Query" again or following steps: 1) close this window;
2) reload the /intel page; 3) re-open this window.

Niantic banned plugin?

mindon commented 11 years ago

no idea, found the issue too

Niantic has updated its API to V3, not working for the extension any more...

its own http requests sometimes also responses

{"error": "urlfetch failed (unretryable): status_code=400 attempt=0 timeout=15 url=http s://dashfe-dot-betaspike.appspot.com/internalrpc/dashboard/getThinnedEntities"}

mollyfud commented 11 years ago

Yep, getting same issue now too! Intel map is working for me though.

sesom commented 11 years ago

Any news?

peta commented 11 years ago

Yes, there are some news ... I fixed tried to fix it. :) I think this issue should be renamed to "Portal query functionality broken since API version 3".

My fix: https://github.com/peta/ingress-portals-finder/blob/issue-30/src . For now you can just copy all contained files to e.g. /Users/peter/Library/Application Support/Google/Chrome/Dev/Default/Extensions/jpddfmddnmfpgdnfgpkpodpkhlobcjkj/1.3.18_0/ and replace the existing ones. That filepath does ofc vary depending on your OS/username/profile.

As said in the commit message, I guess that the zoom level must be passed down to the query function ... I didn't have the time to test it more thorougly. Could somebody of you please test it and report back?

@sesom Bist du zufällig der Klaus, der gestern mitgeholfen hat NM zu begrünen?

wRAR commented 11 years ago

I've zoomed in and the app found two portals in that area. I've zoomed out, back to the maximum range, now the app finds 4 portals at the north of the area (though there are more there) and those two portals found earlier.

mollyfud commented 11 years ago

Yeah, I tested it as well and got a few portals but not all that I should and sometimes doesn't even seem to query.

Thank you greatly for pushing this forward! Hopefully someone (or yourself) can build off this work!

peta commented 11 years ago

Okay then ... I will solve this problem tonight.

mollyfud commented 11 years ago

Will hold you that! ;-) (Kidding of course) (Sort of) ( ;-) )

sesom commented 11 years ago

As already mentioned, it workes a little bit - sometimes no portals are found, sometimes some portals are found. IITC seems to have the same problem, it works when I zoom in to L1+ or L2+ level, but when I zoom out then, most queries will fail.

@peta Ja, der bin ich.

peta commented 11 years ago

UPDATE: User selected zoom levels are now preserved and taken into account when querying tile data. I tested it in my local area and all portals were reported correctly. However, the problem @seson mentioned still exists. I think we need to work around this issue ... somehow "translating" the selected area in the gmaps view into lots of tiles each of which being queried for zoom level 1. But I have no glue if we'd hit some kind of usage limitations the Intel API enforces.

sesom commented 11 years ago

The update does not for me at all, all I get is "Invalid Query!"

peta commented 11 years ago

Strange, can't reproduce this error. The whole issue seems to be more time consuming than I expected. For now I updated it to use getThinnedEntitiesV4 and now it works at least on high levels (14–16) on my machine. Most of the time. I noticed that requests are quite often aborted because of server side timeouts. Intel/IITC can recover from this behaviour. Not so IPF. I also tried to simply convert a huge map area into L16 tiles; the result were > 200 tile parameter objects that were sent to the API at once– the answer was an internal server error (500). o.O I then noticed that both, Intel and IITC split all needed tile parameter objects into multiple requests when querying tile data for large areas. I think we should have a closer look on responsible IITC source code(esp. https://github.com/jonatkins/ingress-intel-total-conversion/blob/master/plugins/portals-list.user.js) and see if we could adapt some of it to IPF.

sesom commented 11 years ago

Strange indeed. Your first fix worked (somehow), but the two updates do not work at all. I select the area and levels and get an "Invalid Query!" error immediately and no output to the JS Console.

sesom commented 11 years ago

I did a fresh install of 1.3.18 and changed ingr.js to your last version: "Invalid Query!"

peta commented 11 years ago

Uff, maybe I should've mentioned that you need to need to copy/replace all files contained in the src directory. (actually only some of it, but replacing the whole directory content is easier) Sorry!

sesom commented 11 years ago

Oh my!

Well, maybe you should have mentioned it or I should have thought a little bit more closely about it. Anyway, now it kinda works for low zoom levels.

mindon commented 11 years ago

updated in v1.4.1, thanks for peta's code.

wRAR commented 11 years ago

I've selected my city as usual (it was the maximum allowed area in the past versions) and the app finds only some of the existing portals (200-300 from 1600)

peta commented 11 years ago

@mindon Please keep this issue open and rename it to "Portal query functionality broken since API version 3" (or something like this). The problem isn't solved yet, my fix just brought it back to life, but as @wRAR said, it still fails at lower zoom levels.

I suppose that we have to distribute all tile parameter objects over multiple requests because there seems to be a maximum of 18 tiles that can be queried in a single request. As I said above, we have should have a look on the IITC source code and check how they solved this.

mollyfud commented 11 years ago

I know for myself, to be really useful it would be great to get back to the point where the larger area is scanable for all levels of portals without having to worry about the zoom level. Again, I do really appreciate the effort you guys are putting in!

mindon commented 11 years ago

it may risk your ingress account now...

peta commented 11 years ago

What happened that you mention it right now?

mindon commented 11 years ago

to get low level portals in large area needs mass queries, that may cause your acc being blocked. i dont think that's what we expected.

NianticLabs is making lots of efforts to stop third-party tools...