Parent transactions currently can be silently rolled-back by a sub-transaction which returns false.
This is risky.
We should probably assume success and always throw if the transaction gets rolled back - rather than just returning false - since the return value may not get checked by the caller, whereas a throw would force somebody to deal with a rolled-back transaction.
Parent transactions currently can be silently rolled-back by a sub-transaction which returns
false.This is risky.
We should probably assume success and always throw if the transaction gets rolled back - rather than just returning
false- since the return value may not get checked by the caller, whereas athrowwould force somebody to deal with a rolled-back transaction.Yeah.