search

mindrevolution / SirTrevor-for-Umbraco

A SirTrevor editor plugin for Umbraco 7+ that integrates.
21 stars 6 forks source link

Add twitter block #6

Open MarcStoecker opened 10 years ago

MarcStoecker commented 10 years ago

Since the beginning the twitter block (part of Sir Trevor's default blocks) is missing from the package. There is no reason for not supporting it.

abjerner commented 10 years ago

The Twitter part requires some server side logic to work. I already have this in my SirTrevor package for Umbraco 6, so I'll look into creating a pull request when I can find the time.

I don't know your take on third party DLLs, but my current code will require a reference to my Skybrud.Social framework to handle the Twitter stuff https://github.com/abjerner/Skybrud.Social

Let me know what your think ;)

MarcStoecker commented 10 years ago

Hey Anders, that is a great idea! I'm very much for collaborating. Your library seems to be under MIT, so that would be fitting. Could you do a PR with just the ST-block, the WebAPI (or whatever) plus your lib? Maybe we could to that on a WIP/dev branch? What would be your take?

abjerner commented 10 years ago

Yes, my library is released under MIT ;)

I'll look into implementing this over the weekend. I can't remember exactly how much Twitter configuration is needed, so if simple, I'll create another pull request - otherwise we can go with a branch.