minds-ai / zoom-drive-connector

Automatically uploads Zoom meeting recordings to Google Drive.
Other
33 stars 8 forks source link

Application Packaging and Testing Improvements #25

Closed MrFlynn closed 5 years ago

MrFlynn commented 5 years ago

This pull request include several packaging and testing improvements for this application.

Packaging Improvements

Testing Improvements

Other Things

MrFlynn commented 5 years ago

@jbedorf I updated the README with the correct package name and the link to the Github help article on how to setup your client to be able to pull images from the Github package registry as well.

In terms of the absolute vs. relative path thing you mentioned to me, that feels a little out of the scope of what I think should be included in the instructions. That's more a Docker specific behavior and not something unique to our project. Besides the example run instructions do demonstrate usage of a full path and not a relative one.

Lastly, have you had the chance to test the 1.1.0 RC yet?

jbedorf commented 5 years ago

@MrFlynn the changes look good and match my experience. The application is running, first results indicate that everything works fine. I'm waiting a bit longer to ensure it works for all the configured meetings before declaring full success.

jbedorf commented 5 years ago

It runs smoothly with multiple meetings configured, so it looks good from my side.