search

minds-ai / zoom-drive-connector

Automatically uploads Zoom meeting recordings to Google Drive.
Other
33 stars 8 forks source link

Repository Cleanup #9

Closed MrFlynn closed 5 years ago

MrFlynn commented 5 years ago

Includes a number of small fixes that were required to bring this repository to the point where I think it would be safe to make it public. The overall list of changes can be found in issue #5.

One thing I would like to complete before we approve the merge is finishing the install instructions. Some components only @jbedorf knows how to properly setup, so I will required his input.

Lastly, one item in #5 will be completed when the repository has been been merged into master. I'll be cleaning the repository of the unsafe configuration file that contains some internal information. Instead of doing it before the merge, doing it after should simplify the process of removing the erroneous file.

MrFlynn commented 5 years ago

I'm planning on removing the config.yaml.example from the repository as it contains a meeting ID that shouldn't be public. Github provides a guide on how to do that. Using BFG seems like a fairly easy solution.

jbedorf commented 5 years ago

Oke, yes that is doable. Removing files is relative easy, modifying them is an other level of pain.

MrFlynn commented 5 years ago

All of the previous comments have been resolved. Let me know if there is anything else you would like me to review.

jbedorf commented 5 years ago

Perfect. I'm messing around with the authentication stuff together with some other tasks once I got something working and implemented I'll let you know.