search

mindsbackyard / galvanic-test

A test environment for rust: test cases & suites, fixtures, and parameterised test cases
Apache License 2.0
52 stars 3 forks source link

Noop dead code #6

Closed austinbes closed 7 years ago

austinbes commented 7 years ago

Fixes #5

I don't know if this is the right way to fix the dead-code warning, but it doesn't generate any extra warnings and the crate tests still pass.

I added a new integration test for simple test suites without mock integration. You'll note that I left your name on the copyright notice at the top of the new file -- my intention is explicitly to have this file match all the others in the crate.

It might be worth creating no_mock versions of some of the other integration tests to help catch other possible corner-cases.

mindsbackyard commented 7 years ago

Thanks for the PR I've added the commit to fix the warning. However I didn't add the duplicate tests. I've configured Travis to run the tests both with and without mock integration and I've fixed the test_suite.rs tests to compile (and run) in both setups (this was an actual bug). The fixes are available in the published v0.1.3