search

mindsdb / dfsql

SQL interface to Pandas
GNU General Public License v3.0
51 stars 9 forks source link

ImportError: cannot import name 'basestring' from 'pyparsing' #41

Open YarShev opened 3 years ago

YarShev commented 3 years ago

Hi guys, I noticed that dfsql doesn't work with new versions of pyparsing (since 3.0.0). This should probably be fixed.

YarShev commented 3 years ago 
import dfsql.utils

./miniconda3/lib/site-packages/dfsql/utils.py in <module>

----> 1 from pyparsing import basestring
      2
      3 from dfsql.engine import pd
      4 from dfsql.exceptions import QueryExecutionException
      5

ImportError: cannot import name 'basestring' from 'pyparsing' (./miniconda3/lib/site-packages/pyparsing/__init__.py)
btseytlin commented 3 years ago

Thanks.

This is fixed in https://github.com/mindsdb/dfsql/pull/39, but the mysterious Ray/Dask issues are preventing me from releasing the fix. You can checkout basestring_fix if you want to test dfsql without this problem

YarShev commented 3 years ago

Yes, I do not see the issue related to the import error in basestring_fix branch but it would be great to have a new release of dfsql to support it in Modin as we normally do.

btseytlin commented 3 years ago

Yes, I do not see the issue related to the import error in basestring_fix branch but it would be great to have a new release of dfsql to support it in Modin as we normally do.

Absolutely! But currently dfsql doesn't pass tests on OSX with Dask engine and on Ubuntu with Ray engine. Can't make a release until this is resolved

YarShev commented 3 years ago

Hope this will happen soon.

YarShev commented 2 years ago

@btseytlin, what is the status on this issue?

btseytlin commented 2 years ago

@btseytlin, what is the status on this issue?

CC @StpMax

tomhuds commented 1 year ago

@StpMax can we close?