search

mindsdb / lightwood

Lightwood is Legos for Machine Learning.
GNU General Public License v3.0
450 stars 94 forks source link

update save method on PredictorInterface class: lightwood/lightwood/api/predictor.py[lines: 141-206] #1131

Closed noraa-july-stoke closed 1 year ago

noraa-july-stoke commented 1 year ago

update save method on PredictorInterface class: lightwood/lightwood/api/predictor.py[lines: 141-206]

The function now optionally takes in a string that that user has gotten from calling code_from_json_ai() and saves it to a dict. @paxcema when I initially was typing my idea out in the issue thread I wasn't sure what the datatype being returned was for code_from_json_ai() but I poked around and found it's a string so can we just save it like that?

See contributor comments above modification... I left some of my thought processes in there so you could follow my logic. (I'm still figuring out the code base).

closes #852

noraa-july-stoke commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

noraa-july-stoke commented 1 year ago

I removed the optional bit from the json_ai_code since we changed it to a new function altogether. I should have done that in the first place 😅. I can probably tackle the next bit (producing json_ai internally) next week at some point.

paxcema commented 1 year ago

Thanks for your contribution @noraa-july-stoke 🙌