Fix analyze endpoint - Githubissues

mindsdb / mindsdb_js_sdk

DEPRICATED

http://mindsdb.com

MIT License

12 stars 3 forks source link

Fix analyze endpoint #7

Closed ZoranPandovski closed 4 years ago

ZoranPandovski commented 4 years ago

Change analyze to call new API path
Fixes #8

George3d6 commented 4 years ago

Ok, so the whatever in relation to your comment was there because predictors required a predictor name, so when the analyze endpoint was there you needed to pass a name (which could be whatever since the server didn't use it, it's just how pathing works).

The new endpoint under datasources shouldn't need that.

George3d6 commented 4 years ago

The call should be /datasources/<datasource_name>/analyze and the data_source_name url argument shouldn't be required, if possible make those changes and test them to make sure it works correctly.

ZoranPandovski commented 4 years ago

Ok, the hardcoded value was removed and the name was added to the path. If (this.name) is not available will take default value.

George3d6 commented 4 years ago

Ok, if the name is added to the path it should no longer be needed in the URL query. So remove it from there and merge the PR once that's done.