'-'(MINUS) should be not allowed in Identifier names

mindsdb / mindsdb_python_sdk

The Python SDK for MindsDB Server

GNU General Public License v3.0

30 stars 11 forks source link

'-'(MINUS) should be not allowed in Identifier names #88

Closed parthiv11 closed 11 months ago

parthiv11 commented 11 months ago

Your Environment

Python version:
Operating system: windows 10
Mindsdb Python SDK version:
Additional info if applicable:

Please describe your issue and how we can replicate it

While using py-sdk to create model, project, db and views name can include "-"(Minus) sign which I think should not expected. Sanatize input name before sending to REST session.

Same issue can also be in js-sdk (not sure about it)

ea-rus commented 11 months ago

Do you meant it is possible to create project with '-' using python sdk, right? It yes, to which problems or bugs does it lead?

parthiv11 commented 11 months ago

On cloud SQL Editor it is not permissible to use "-" MINUS sign into identifiers

parthiv11 commented 11 months ago

1701432703327918902595838578538

ea-rus commented 11 months ago

It is a web editor. You can use backquotes there:

create model `crx-openai4` ...

parthiv11 commented 11 months ago

Ohh 😮😮 ..

Sorry I didn't know that