mindsdb / mindsdb_sql

SQL parser and planner used by MindsDB
https://mindsdb.com
GNU General Public License v3.0
57 stars 21 forks source link

mindsdb_sql import speed #236

Closed ea-rus closed 1 year ago

ea-rus commented 2 years ago

Import of mindsdb_sql module takes around a second. It looks like import of Parser module takes a most of that time

ea-rus commented 2 years ago

133f089

ea-rus commented 1 year ago

I think the next we can do for speed up is reduce syntax complexity or migrate to another parse library

tomhuds commented 1 year ago

Relevant when starting new HF subprocess (needs to import), however now not creating new subprocess for each HF query, so not as relevant.

ea-rus commented 1 year ago

Optimization in forked repo makes import 3 times faster https://github.com/ea-rus/sly

paxcema commented 1 year ago

Given that sly is retired, perhaps it makes sense to turn this fork into a mindsdb-sly package instead?

ea-rus commented 1 year ago

Yes, it is a question to discuss, what to do:

ea-rus commented 1 year ago

Released in #281