search

mindshape-GmbH / mindshape_cookie_consent

This extension provides functionality to create a customizable cookie consent for your website. It is developed for flexibility to be customized in accordance to your data security guidelines.
10 stars 13 forks source link

TypeError in List View, TYPO3 12.4.9 #47

Closed jungedigitale closed 6 months ago

jungedigitale commented 6 months ago

After switching from TYPO3 version 12.4.8 to 12.4.9 we get a TypeError after accessing List view to the Page, where the Cookie Config ist stored:

Mindshape\MindshapeCookieConsent\UserFunc\ConfigurationTcaUserFunc::sitesItemsProcFunc(): Argument #2 ($tcaSelectItems) must be of type TYPO3\CMS\Backend\Form\FormDataProvider\TcaSelectItems, TYPO3\CMS\Core\DataHandling\ItemProcessingService given

in [...]/vendor/mindshape/mindshape-cookie-consent/Classes/UserFunc/ConfigurationTcaUserFunc.php line 44

Thanks & best regards -Markus

featdd commented 6 months ago

Hi @jungedigitale,

I have to test this, haven't done the newest update yet. Have you done some changes to the TCA of this extension? Otherwise this might be a breaking change in the core or something.

Greetings Daniel

jungedigitale commented 6 months ago

Hi Daniel, thanks for the fast reply! No we haven't done any changes to the TCA of this extension, it is a standard implementation.

thanks & best regards -Markus

LimeUwe commented 6 months ago

I have the same problem here. Looking at the paramters, there is a unued parameter tcaSelectItems which is not of the correct type:

public function sitesItemsProcFunc(array $parameters, TcaSelectItems $tcaSelectItems): void

It's not used anywhere in the method, so I think it can be removed? List view works then.

birgitberlin commented 6 months ago

I can confirm this problem.

featdd commented 6 months ago

Hi @jungedigitale, @LimeUwe, @birgitberlin,

I just pushed a commit that should fix the problem: 2bd7bfd9c3e15249b0fc567a16ed802c0b377dda Can you guys confirm me this also works for you?

I don't know if this counts as a breaking change but this will break some peoples code, will have to check some other extensions later too... Luckily in this case the parameter was unused anyway and just there for completion, so I could just remove it.

I will try to push an update to TER next week.

Greetings Daniel

jungedigitale commented 6 months ago

Hi @featdd, Thank you, the fix seems to have eliminated the issue! best -Markus

featdd commented 6 months ago

Hi @jungedigitale, @LimeUwe, @birgitberlin,

I just pushed an update to TER containing this bugfix.

Greetings and merry christmas Daniel

jungedigitale commented 5 months ago

Thank you very much for your work & happy new year!