search

mindshape-GmbH / mindshape_cookie_consent

This extension provides functionality to create a customizable cookie consent for your website. It is developed for flexibility to be customized in accordance to your data security guidelines.
10 stars 13 forks source link

PHP Warning: Undefined array key "site" in `Classes/UserFunc/ConfigurationTcaUserFunc.php` line 46 with TYPO3 12.4.10 #49

Open mkempe opened 5 months ago

mkempe commented 5 months ago

Hi,

after switching from TYPO3 version 12.4.9 to 12.4.10 we get a TypeError in the backend when using the list view.

I think the problem is, that the passed $parameters changed with the new version. $parameters['row'] does not contain the site and sys_language_uid anymore. Instead $parameters['site'] contains now a site object.

PS: Many thanks for the extension and the maintenance of it.

featdd commented 5 months ago

Hi @mkempe,

thanks for the hint, I'll have to test this myself. Maybe TYPO3 introduced another breaking change here, not the only one in the last time...

Greetings Daniel

mkempe commented 5 months ago

Hey @featdd,

many thanks for looking into it. I also think it's bad, maybe they roll it back and we're waiting for the next release.

Have a nice week.

featdd commented 5 months ago

Hi @mkempe,

this really seems to be a core issue, I created a ticket on forger for this. Maybe this will get fixed quick so I'll wait a few days or release a workaround later.

Greetings Daniel

mkempe commented 4 months ago

Hi @featdd,

hope I'm not disturbing you. Have you heard anything new about the issue? Unfortunately, the bug has not yet been fixed in the latest security release.

featdd commented 4 months ago

Hi @mkempe,

yes there is still no fix to the issue. (you can see the progress here) I'll probably have to look for a workaround, give me some time to look for it.

Greetings Daniel

abvdveen commented 2 months ago

Any news on this?

featdd commented 2 months ago

Hi @abvdveen & @mkempe,

sorry for the long waiting, initially hoped to get this fixed faster in the core, due to backwards incompatibility. I just implemented a workaround, I would be happy to hear your feedback before an official release.

See: 11c542daeee00041e56df5702ff04d313a7540a9

Greetings Daniel

abvdveen commented 2 months ago

Looks ok to me. No errors anymore, everything seems to be working fine.

mkempe commented 2 months ago

Hi @featdd,

many thanks for taking the time to workaround a bug in core. I have tested the changes with the current version (12.4.13). Everything works as before. Thanks again.

featdd commented 2 months ago

Hi @abvdveen & @mkempe,

I just released an update (3.2.0) for packagist & TER with the workaround.

I'll leave this issue open as a reminder to fix this properly once the core bug is solved.

Greetings Daniel

mkempe commented 2 months ago

Hi @featdd,

many thanks for the new release. Have a great day.