search

mindstorm38 / portablemc

A fast, reliable and cross-platform command-line Minecraft launcher and API for developers. Including fast and easy installation of common mod loaders such as Fabric, Forge, NeoForge and Quilt.
https://pypi.org/project/portablemc/
GNU General Public License v3.0
320 stars 19 forks source link

portablemc start forge:1.20.1-latest does not work #189

Closed MisileLab closed 4 months ago

MisileLab commented 7 months ago

Log:

[FAILED] Version forge-1.20.1-??? not found
MisileLab commented 7 months ago

1.20.1 has no latest, it has only recommended so maybe when latest not found, use recommended as fallback

mindstorm38 commented 7 months ago

Should be how it works, hope it's not new issue with neoforge

mindstorm38 commented 7 months ago

Ok I think that I understand, you start with forge:1.20.1-latest? If this is the case, just use forge:1.20.1 instead, it uses recommended and then latest as fallback, should be what you need?

MisileLab commented 7 months ago

I want latest at first and recommend as fallback (because I want newer version)

mindstorm38 commented 7 months ago

So are you suggesting inverting the default fallback order or just be less strict about -latest and -recommended when one is not available? (I prefer the latter)

MisileLab commented 7 months ago

I prefer last one(just give warning when not avaliable and fallback)

mindstorm38 commented 7 months ago

Looks good to me, I'll work on that.

mindstorm38 commented 5 months ago

Implemented in next release!

mindstorm38 commented 4 months ago

Release 4.2.1, implemented this fallback