search

mindstorm38 / portablemc

A fast, reliable and cross-platform command-line Minecraft launcher and API for developers. Including fast and easy installation of common mod loaders such as Fabric, Forge, NeoForge and Quilt.
https://pypi.org/project/portablemc/
GNU General Public License v3.0
320 stars 19 forks source link

Support for legacyfabric #197

Closed BluCobalt closed 3 months ago

BluCobalt commented 4 months ago

@Legacy-Fabric ports the fabric toolchain to versions pre 1.14. This pr just adds legacyfabric's meta, using it for versions 1.3.2-1.13.2.

mindstorm38 commented 4 months ago

Also, could you retarget your pull request to the v4.3 branch? It is at the same commit as main, so this should be a no-op on your side.

mindstorm38 commented 4 months ago

Any update on your side? If you need help, do not hesitate, I can just merge this one on the v4.3 branch and do the work myself.

mindstorm38 commented 3 months ago

If you don't answer by tomorrow I'll merge your work and do the modifications myself.

BluCobalt commented 3 months ago

Sorry, I got completely caught up in school and forgot about this. I'd be happy to work on it today.

mindstorm38 commented 3 months ago

No hurry tho, I thought you really forgot this pr, and I was going to modify it, keeping your work of course.

BluCobalt commented 3 months ago

Should I add lang for everything loader specific, or just for legacyfabric_prefix for the help text in parse.py?

BluCobalt commented 3 months ago

See #205