mindstorm38 / portablemc

A fast, reliable and cross-platform command-line Minecraft launcher and API for developers. Including fast and easy installation of common mod loaders such as Fabric, Forge, NeoForge and Quilt.
https://pypi.org/project/portablemc/
GNU General Public License v3.0
354 stars 20 forks source link

Version 4.3 #204

Closed mindstorm38 closed 5 months ago

mindstorm38 commented 6 months ago

Changes

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 31.53153% with 76 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@e98452a). Click here to learn what that means.

Files Patch % Lines
portablemc/cli/__init__.py 5.76% 49 Missing :warning:
portablemc/auth.py 22.22% 7 Missing :warning:
portablemc/fabric.py 75.86% 7 Missing :warning:
portablemc/download.py 0.00% 5 Missing :warning:
portablemc/standard.py 28.57% 5 Missing :warning:
portablemc/cli/output.py 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #204 +/- ## ======================================= Coverage ? 63.60% ======================================= Files ? 20 Lines ? 3314 Branches ? 0 ======================================= Hits ? 2108 Misses ? 1206 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mindstorm38 commented 5 months ago

I should really really handle this PR now, it's been a month now.

mindstorm38 commented 5 months ago

Feel free to review, I'll wait until this weekend (april 20th) to release it, I also hope that I can fix #198 which is a rare problem yet insanely critical.

mindstorm38 commented 5 months ago

Will be released later, probably around 23h UTC+2