search

mindstorm38 / portablemc

A fast, reliable and cross-platform command-line Minecraft launcher and API for developers. Including fast and easy installation of common mod loaders such as Fabric, Forge, NeoForge and Quilt.
https://pypi.org/project/portablemc/
GNU General Public License v3.0
372 stars 20 forks source link

Support for LegacyFabric #205

Closed BluCobalt closed 7 months ago

BluCobalt commented 8 months ago

Continuation of #197 but targetting v4.3 instead of main

mindstorm38 commented 8 months ago

Thank you! It's really looking good. Could you fix (remove) modifications by your automatic formatter? This added many space in some places.

mindstorm38 commented 8 months ago

Oops I'm on mobile and misclicked resolving, yes you're right about the message. You can just add precision for legacy fabric in parentheses.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 63.73%. Comparing base (10b4b14) to head (e05430b).

Files Patch % Lines
portablemc/cli/__init__.py 0.00% 13 Missing :warning:
portablemc/fabric.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## v4.3 #205 +/- ## ========================================== - Coverage 63.89% 63.73% -0.17% ========================================== Files 20 20 Lines 3271 3284 +13 ========================================== + Hits 2090 2093 +3 - Misses 1181 1191 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mindstorm38 commented 8 months ago

(don't care of codecov)