search

mindstorm38 / portablemc

A fast, reliable and cross-platform command-line Minecraft launcher and API for developers. Including fast and easy installation of common mod loaders such as Fabric, Forge, NeoForge and Quilt.
https://pypi.org/project/portablemc/
GNU General Public License v3.0
320 stars 19 forks source link

XML output stream parsing not properly detected when early errors happens #209

Closed mindstorm38 closed 2 months ago

mindstorm38 commented 2 months ago

This happened when testing LegacyFabric (from #204), an early error with 'ScriptEngineManager' tricked the output type detection into thinking this isn't XML, this should be improved for 4.3!

[  OK  ] Resolved legacyfabric loader 0.15.9 for 1.12.2
[  OK  ] Loaded version legacyfabric-1.12.2-0.15.9 (fetched)
[  OK  ] Loaded version 1.12.2     
[  OK  ] Loaded Mojang java 8u202
[  OK  ] Checked version jar
[  OK  ] Checked 1305 assets version 1.12
[  OK  ] Checked 39 class and 3 native libraries
[  OK  ] Using logger client-1.12
[  OK  ] Download: 223/223  28.7 MB @ 19.6 MB/s 

ScriptEngineManager providers.next(): javax.script.ScriptEngineFactory: Provider jdk.nashorn.api.scripting.NashornScriptEngineFactory not found
  <log4j:Event logger="FabricLoader/GameProvider" timestamp="1712516268800" level="INFO" thread="main">
    <log4j:Message><![CDATA[Loading Minecraft 1.12.2 with Fabric Loader 0.15.9]]></log4j:Message>
  </log4j:Event>
  <log4j:Event logger="FabricLoader/GameRemap" timestamp="1712516268801" level="INFO" thread="main">
    <log4j:Message><![CDATA[Fabric is preparing JARs on first launch, this may take a few seconds...]]></log4j:Message>