Compressing of assets to increase site speed

mindwaveventures / good-thinking

Good Thinking

https://www.good-thinking.uk

4 stars 1 forks source link

Compressing of assets to increase site speed #300

Open ellemindwave opened 7 years ago

ellemindwave commented 7 years ago

This is lower priority, dependent on time this sprint

reddog commented 6 years ago

@ellemindwave Is this expected to be completed in https://github.com/mindwaveventures/cms/milestone/5 ? If so, @Danwhy could we get a comment on what would be implemented and a time estimate?

Danwhy commented 6 years ago

A lot of the guides to implementing this with django I've found have been specifically around using servers such as nginx, I haven't been able to find much to do with implementing it using heroku.

I'd suggest that I spend no more than two hours looking into it again this sprint, then if I don't have any success, it might be more beneficial/time efficient to wait until we've transferred the site away from heroku.

reddog commented 6 years ago

@Danwhy thanks for that. Rather than hunt around for & possibly implement Heroku-specific optimisations, should we leave this until further on in the sprint and see if #284 isn't done already?

Cleop commented 6 years ago

@Danwhy @reddog - is site speed now faster with AWS and the work @Danwhy put in? Is this issue still relevant or can it be closed?

reddog commented 6 years ago

@Cleop I think the work to concatenate & compress assets is beneficial regardless of where the site is hosted (Heroku, AWS or elsewhere) since it should result a better browsing experience for clients.

The homepage loading waterfall at https://github.com/mindwaveventures/cms/issues/516#issuecomment-335807449 shows just a single JS and CSS file from the webserver which is great. Both are also minified, which is also great.

The scripts.js file is 105KB and it would be good to ensure that only those scripts required are included in the minification - is that the case?