search

mineadmin / components

mine-admin library
Apache License 2.0
10 stars 21 forks source link

Add PluginNotFoundException and make Plugin::read more safe #91

Closed BadJacky closed 3 months ago

BadJacky commented 3 months ago

Add PluginNotFoundException and refactor Plugin class

• Add PluginNotFoundException in AppStore to handle missing plugins • Modify Plugin::load() to throw PluginNotFoundException when plugin is not found • Add tests for PluginNotFoundException and updated Plugin methods

boring-cyborg[bot] commented 3 months ago

Thanks for opening this pull request! Please check out our contributing guidelines.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 3.90%. Comparing base (37e4ce5) to head (638036c).

Files Patch % Lines
src/AppStore/src/Plugin.php 0.00% 8 Missing :warning:
...AppStore/src/Exception/PluginNotFoundException.php 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.0 #91 +/- ## ======================================= Coverage 3.90% 3.90% Complexity 2471 2471 ======================================= Files 257 258 +1 Lines 7272 7270 -2 ======================================= Hits 284 284 + Misses 6988 6986 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

boring-cyborg[bot] commented 3 months ago

Awesome work, congrats on your first merged pull request!