Add inspection for targeting the same class multiple times in a mixin

minecraft-dev / MinecraftDev

Plugin for IntelliJ IDEA that gives special support for Minecraft modding projects.

https://minecraftdev.org/

GNU Lesser General Public License v3.0

1.52k stars 186 forks source link

Open O7410 opened 3 months ago

O7410 commented 3 months ago

Currently it's a weak warning

RedNesto commented 3 months ago

This is looking pretty good, there's a few things to note:

this does not cover cases where a class literal and string target both reference the same class
it would be nice to have some tests for this inspection, you can use InvalidInjectorMethodSignatureInspectionTest as a reference.
you should be fine getting PsiClass.mixinTargets once and pass it around, instead of hitting the cache again and again

O7410 commented 3 months ago

Take a look at the latest commit