search

minecraft-linux / mcpelauncher-manifest

The main repository for the Linux and Mac OS Bedrock edition Minecraft launcher.
https://minecraft-linux.github.io
GNU General Public License v3.0
926 stars 100 forks source link

Not enough space on device #988

Open marvin1099 opened 3 months ago

marvin1099 commented 3 months ago

Describe the bug When trying to download a big map from the marketplace it complains that i don't have enough space, my drives sill have massive amounts of space so this cant be what is going on.

To Reproduce Steps to reproduce the behavior:

  1. Go to the Marketplace
  2. Download something like the Hermitcaft season 9 map (that is what I tried)
  3. It complains that you don't have enough space, even if you have save on your drives

Expected behavior It should download if you have space

Screenshots Screenshot_20240525_120058

Desktop (please complete the following information):

style-nine commented 3 months ago

This bug persists for me even if I delete my ~/.local/share/mcpelauncher folder and relogin/redownload everything from scratch.

Skylandy commented 2 months ago

Same issue but with a texture pack exceeding 400 MB (432MB to be precise) instead of a map (has custom models etc). Also I’m on the steamdeck discover version (seems part of this?) Might be some kind of per download size limit?

style-nine commented 2 months ago

I just moved completely to a totally new system, installed the new update (1.21), and I still cannot download the HC S9 map. It just keeps saying I don't have space (even though I have 270G).

ChristopherHX commented 2 months ago

I can imagine what is causing this on the launcher side by not telling the game the available disk space, but I don't have any marketplace content with size > 141MB

marvin1099 commented 2 months ago

I can imagine what is causing this on the launcher side by not telling the game the available disk space, but I don't have any marketplace content with size > 141MB

You can also test with the hermitcraft s9 map, its free and above 400mb.

ChristopherHX commented 2 months ago

@marvin1099 Thank you, I can now look at fixing this

ChristopherHX commented 2 months ago

ok found a way to bypass the error, that should land in nightly within 24hours https://github.com/minecraft-linux/mcpelauncher-manifest/releases/tag/nightly

By returning 1024^4 of allocatable bytes on disk, it sounds like you found a magic number that is allowed for old android that doesn't have the android api to make a disk space query

style-nine commented 2 months ago

Okay, now it works.

ChristopherHX commented 1 month ago

first regression of the change #1019 for the 32bit game, needs to be 64bit only

The question here is where is the int overflow, in the launcher or big binary blob aka minecraft

marvin1099 commented 1 month ago

well since it works now should this be closed, ore are you still working on full support?