minecraft-linux / mcpelauncher-ui-manifest

Manifest for the Qt launcher part, which lets you download and manage Minecraft versions and can assist in troubleshooting.
https://minecraft-linux.github.io
26 stars 8 forks source link

Security concerns #33

Closed gyoo18 closed 3 years ago

gyoo18 commented 3 years ago

Hi, I just logged in to my google account on the laucher when I received a notification about an unknown device that is definitly not one of mine logging in my account. I would like to know if it is related to the launcher and if it is the doing of it, I would like to get some explanations please.

ChristopherHX commented 3 years ago

You mean that the launcher identifies itself as a samsung galaxy? Google blocked this launcher, because it was idendified by google as qtwebengine on linux/mac. Related Change: https://github.com/minecraft-linux/playdl-signin-ui-qt/compare/20c9f5bf5d8538210b72415935d80f9315f7e85e...9336f1f6ec801b81ab5ea493aa2d693dcfbb7f52#diff-f60d99dd783b889386dcd62f62a46a9d98ef41655b9ed10502a0261d1fec22ee

Before this change google greets you that this device is insecure, since ca. 2019.8

Another points of missing security:

gyoo18 commented 3 years ago

Ok, so if I understand correctly, nobody signed up in my account and it's just that my chromebook didn't identify itself as a chromebook, but as a samsung galaxy. Thanks for reassuring me! :)

ChristopherHX commented 3 years ago

Added as a warning in v0.2.3