search

minecrafter / RedisBungee

The leading player synchronization system for BungeeCord
https://www.spigotmc.org/resources/redisbungee.13494/
Eclipse Public License 1.0
157 stars 122 forks source link

Fix channel for bungee 1.13 #61

Closed detobel36 closed 5 years ago

detobel36 commented 5 years ago

Try to fix #60 : channel for bungee 1.13

sgdc3 commented 5 years ago

Did you test it? Does it support messages from 1.12 servers and old plugins?

detobel36 commented 5 years ago

No it doesn't support old message.
I think it's not possible to make retro support.

But you can use new channel message on old version... I define the new channel like this: redisbungee:RedisBungee (which replace RedisBungee).

sgdc3 commented 5 years ago

i think some type of remapping is possible, at least to support channels from 1.12 servers

detobel36 commented 5 years ago

I think that BungeeCord 1.13 doesn't read channel without any : (except for BungeeCord).
So, we can have on plugin with two channels: redisbungee:RedisBungee and RedisBungee but only one of the two will work (depending of the version of BungeeCord).
But for spigot plugin, I think you don't have choice... You need to update your channel name.

sgdc3 commented 5 years ago

no i think the restriction is only soigot side, @electronicboy right?

detobel36 commented 5 years ago

Ho ok...
If it is the case, add two channels is a solution to accept both :smiley:

electronicboy commented 5 years ago

1.13 bungee will fire the custom payload event but will basically "modernise" the contents to be able to read it (Basically, legacy:)

The 1.13 server will also not allow you to send a plugin message without a : in there due to implementation constraints (Vanilla actually uses a MinecraftKey in there, equiv to bukkits NamespacedKey)

detobel36 commented 5 years ago

So I update the code for this pull request.
The channel is now: legacy:RedisBungee and I read/send message also on RedisBungee (to work with old plugin).

:warning: I don't test it. Do not hesitate to comment if you have some problem or if it work.

ghost commented 5 years ago

Sorry for the delay guys, I'll merge this soon :)

ghost commented 5 years ago

Resolved trough https://github.com/minecrafter/RedisBungee/commit/429ed39160471d0e8289ca6b662f061a08d281b2 sorry for the delay :)

joseluisgp commented 5 years ago

[19:15:57 ERROR]: Couldn't register custom payload java.lang.IllegalArgumentException: Channel must be entirely lowercase (attempted to use legacy:RedisBungee)

Is this error related with this issue?