search

mineiros-io / terraform-aws-cognito-user-pool

A Terraform module to create and manage Cognito User Pools (Simple and Secure User Sign-Up, Sign-In, and Access Control) on Amazon Web Services (AWS). https://aws.amazon.com/cognito
Apache License 2.0
60 stars 45 forks source link

user-attribute-update-settings #72

Open SAOPP opened 1 year ago

SAOPP commented 1 year ago

Prevents instant use of a changed user account without data verification.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cognito-userpool-userattributeupdatesettings.html

nnsense commented 1 year ago

It would be great to have this merged, it's an important feature and it's not really dangerous to merge @mariux :)

matteo-ssys commented 1 year ago

Hi, sorry to bother but we had to use this PR source repo in our deployments because we require to set the attributes_require_verification_before_update attribute. This isn't a huge change, and I can assure you (since we've been using it even in prod) that it works, would it be possible to review/merge so that we can use mineiros as a source instead of the PR's repo (which might be deleted at any time)? Thanks! :)

SAOPP commented 1 year ago

Hi, sorry to bother but we had to use this PR source repo in our deployments because we require to set the attributes_require_verification_before_update attribute. This isn't a huge change, and I can assure you (since we've been using it even in prod) that it works, would it be possible to review/merge so that we can use mineiros as a source instead of the PR's repo (which might be deleted at any time)? Thanks! :)

Hello! I assure u that it will not be deleted, because I also use my (this) repository in prod. I still hope for a merge from original authors.

matteo-ssys commented 1 year ago

Hi Anton, thanks, that's reassuring, also because, judging by the last update to this repo (in 2022) and the silence over the last 4 months, I'm starting to lose hope..

soerenmartius commented 1 year ago

Hi Guys,

Sorry for the delay. Unfortunately, we can't work on this module anymore as we are working full-time on https://github.com/terramate-io/terramate. We will deffo review all PRs in the future. I just can't commit to a timeline as of now. Thank You