mineiros-io / terraform-aws-lambda-function

A Terraform module for deploying and managing Lambda functions on Amazon Web Services (AWS). https://aws.amazon.com/lambda/
Apache License 2.0
42 stars 24 forks source link

Inialize new terraform-aws-lambda-function module and add aws_lambda_function resource #1

Closed soerenmartius closed 4 years ago

soerenmartius commented 4 years ago

Work in progress

mariux commented 4 years ago

@soerenmartius I know this is WIP, but please do not forget to open several small PRs for easier and faster reviews.. so first, adjust the template to the actual module... so we get stuff merged step by step but in a total way faster... as a rule of thumb: whenever your commit message needs an "and" to describe what it does, consider splitting it.

soerenmartius commented 4 years ago

@soerenmartius I know this is WIP, but please do not forget to open several small PRs for easier and faster reviews.. so first, adjust the template to the actual module... so we get stuff merged step by step but in a total way faster... as a rule of thumb: whenever your commit message needs an "and" to describe what it does, consider splitting it.

OK, gotcha. Been copying the existing work from the other repository. Will adjust the PR later when I've got something working in place.

mariux commented 4 years ago

OK, gotcha. Been copying the existing work from the other repository. will adjust the PR later when I've got something working in place.

okay... but try to get the stuff that is just setting up the template adjustments merged first... so we just review code and docs, examples, tests in small unrelated PRs.