mineiros-io / terraform-aws-s3-bucket

A Terraform module to create a Simple Storage Service (S3) Bucket on Amazon Web Services (AWS). https://aws.amazon.com/s3/
Apache License 2.0
61 stars 40 forks source link

Use docker hub #15

Closed soerenmartius closed 4 years ago

soerenmartius commented 4 years ago

This is a conceptual PR with that contains ongoing work and isn't finished or ready for review yet. Just asking for early feedback.

I moved the Dockerfile to a new build-tools repository. Also, I've set up the repository in docker hub and enabled auto-build also. The Makefile will now pull the image from hub.docker.com instead of building it locally.

To-Do:

soerenmartius commented 4 years ago

ok, that works as expected already. The next step will be to move the Makefile to the build-tools repository and to include in the modules repository with curl.

Just try to run make or make help inside the directory.

The biggest question remains though: Can we get this to work on a windows powershell 👎

soerenmartius commented 4 years ago

rdy for final review @mariux