search

mineiros-io / terraform-github-repository

A Terraform module to manage GitHub Repositories. https://github.com/
Apache License 2.0
156 stars 100 forks source link

feat: add v4 branch protections #128

Closed taharah closed 1 year ago

taharah commented 2 years ago

Adds v4 branch protections as a separate resource. If v4 branch protections are set, then it will disable the v3 branch protection resource to prevent any conflicts.

Resolves #124

Signed-off-by: Trevor Wood Trevor.G.Wood@gmail.com

anthr76 commented 1 year ago

This appears to need a rebase.

kevcube commented 1 year ago

@taharah do you have time to get this ready for review? This would be helpful for my team. If now I’m happy to take it over.

kevcube commented 1 year ago

Also - optional attrs came out of preview so that part can be removed! (Min tf version will need to be bumped up)

taharah commented 1 year ago

Also - optional attrs came out of preview so that part can be removed! (Min tf version will need to be bumped up)

I'll get this updated tonight for TF 1.3+. On another note, should this continue to maintain backwards compatibility for v3 protections, or would a breaking change with the appropriate version bump be acceptable?

taharah commented 1 year ago

@anthr76 or @kevcube this has been updated and is ready for review.

anthr76 commented 1 year ago

I am not a maintainer of this repo, though I'm happy to give it a second set of eyes.

jvandijk commented 1 year ago

I'm not a maintainer either. Only a happy user, and hopefully also able to help to get this into the main branch.

soerenmartius commented 1 year ago

hey guys, sorry for the delay! We'll review this shortly and come back to you!

taharah commented 1 year ago

@mariux or @soerenmartius would it be possible to get a review please?

mariux commented 1 year ago

sorry for the delay... we added the provided feature but in a slightly different way to support computed values in some scenarios also restoring terraform 1.0 compatibility.

We just released the new version.

Thanks again for providing the feature.

jvandijk commented 1 year ago

Thank you @mariux & @taharah . I've updated my configuration to match your changes and bumped to v0.18.0!