search

mineiros-io / terraform-github-repository

A Terraform module to manage GitHub Repositories. https://github.com/
Apache License 2.0
156 stars 100 forks source link

Support for Always suggest updating pull request branches #132

Open dmilcevski opened 1 year ago

dmilcevski commented 1 year ago

Hi,

Is there a support for "Always suggest updating pull request branches"?

Screen Shot 2022-10-04 at 11 37 45

If not, is there a timeline for this to be supported?

Thanks!

soerenmartius commented 1 year ago

Hi @dmilcevski,

Thanks for reaching out! Unfortunately, this is not yet supported by the provider. There's an opened request to implement this feature in https://github.com/integrations/terraform-provider-github/issues/1072. We will add support for this module once it has been added to the provider.

Again, thanks for reaching out and for requesting this!

mariux commented 1 year ago

added in https://github.com/integrations/terraform-provider-github/releases/tag/v5.7.0 but as this breaks branch protections v3, we can not yet update until branch protections v3 are fixed upstream: https://github.com/integrations/terraform-provider-github/issues/1307

0x46616c6b commented 1 year ago

Your mentioned fix in the GitHub Provider was merged. So it is possible to implement this now :-)

tobiasehlert commented 1 year ago

Created PR #155 that adds possibility to set allow_update_branch to true.