search

mineiros-io / terraform-github-repository

A Terraform module to manage GitHub Repositories. https://github.com/
Apache License 2.0
156 stars 100 forks source link

Add support for configuring default squash and merge commit titles and messages #137

Open soerenmartius opened 1 year ago

soerenmartius commented 1 year ago

@mariux is this good to go?

soerenmartius commented 1 year ago

@mariux the tests are failing after applying your provided suggestions ... not a priority though https://github.com/mineiros-io/terraform-github-repository/actions/runs/3394710192/jobs/5643646371

anthr76 commented 1 year ago

Is this ready to be merged?

gaima8 commented 1 year ago

Is this PR still actually a draft, or once conflicts are resolved, is it ready for approval and merging? Githubs default squash strategy grinds my gears.

Thanks

bodgit commented 1 year ago

Would be good to get this over the line. I can't even manually tweak the repository settings as the current release of this module resets the squash settings back to the defaults.

marcjay commented 1 year ago

I think this PR might be ready to review?

marko-fabry commented 11 months ago

Hello all! What is the ETA on merging this one? We forked it for the time being just for this PR and it seems to work as expected.