Added security_and_analysis block support - Githubissues

mineiros-io / terraform-github-repository

A Terraform module to manage GitHub Repositories. https://github.com/

Apache License 2.0

156 stars 100 forks source link

Added security_and_analysis block support #143

Open iluwaa opened 1 year ago

hisabimbola commented 1 year ago

@mineiros-ci @mineiros-team any update on when this PR can be merged. It'll really be useful to have security configuration

gaima8 commented 1 year ago

As I understand it the container used to run checks on PR (make test/docker/pre-commit) has terraform v1.1.7.

This PR uses optional attributes with a default value. terraform didn't add support for optional attributes with a default value until v1.3 though. https://developer.hashicorp.com/terraform/language/v1.1.x/expressions/type-constraints#experimental-optional-object-type-attributes https://developer.hashicorp.com/terraform/language/expressions/type-constraints#optional-object-type-attributes

Among other things https://github.com/mineiros-io/build-tools/blob/422e2711d58426624e1b3db54eff8d1620682a2c/Makefile#L8 would need to change to support this.