search

mineiros-io / terraform-github-repository

A Terraform module to manage GitHub Repositories. https://github.com/
Apache License 2.0
159 stars 105 forks source link

Add support for discussions #153

Open meddlin opened 1 year ago

meddlin commented 1 year ago

It would be incredibly helpful to allow this module to support GitHub's Discussions feature, similar to how the has_issues, has_wiki, and has_projects works.

https://github.com/mineiros-io/terraform-github-repository/blob/ee6001a0b791af814d7f0c015da0c7ca204f3fbe/variables.tf#L57

https://github.com/mineiros-io/terraform-github-repository/blob/ee6001a0b791af814d7f0c015da0c7ca204f3fbe/variables.tf#L63

https://github.com/mineiros-io/terraform-github-repository/blob/ee6001a0b791af814d7f0c015da0c7ca204f3fbe/variables.tf#L69

meddlin commented 1 year ago

This PR may be beneficial to this issue: https://github.com/integrations/terraform-provider-github/pull/1443 And this open issue, too: https://github.com/integrations/terraform-provider-github/issues/1442

Apologies for not including this initially. I'm still learning HCL, and this repo's relationship with terraform-provider-github.

shinenelson commented 1 year ago

This feature was introduced in v5.14.0. This means that we would have to bump the minimum provider requirements to >= 5.14.0.

Since #148 is already bumping the minimum provider requirement to >= 5.16.0, and it has other minor boolean changes as well, maybe the changes required to resolve this issue could also be merged in along with it.

Note to maintainers : I offered to obsolete the defaults variable in #148. I could create a pull request that resolves this issue as well according to your preference.