search

mineiros-io / terraform-github-repository

A Terraform module to manage GitHub Repositories. https://github.com/
Apache License 2.0
159 stars 105 forks source link

feat: add support for `allow_update_branch` #155

Open tobiasehlert opened 1 year ago

tobiasehlert commented 1 year ago

fix #132 rel #148 (similar except that it's not updating provider versions)

tobiasehlert commented 1 year ago

As much as I want this change to be merged in without a breaking change, this change would also require a breaking change since the minimum required provider version would have to be bumped to >= 5.7.0.

The current provider version constraint for this module is >= 4.20, < 6.0.

https://github.com/mineiros-io/terraform-github-repository/blob/ee6001a0b791af814d7f0c015da0c7ca204f3fbe/versions.tf#L12

allow_update_branch was added in provider version v5.7.0. So the minimum required version for this module should be bumped to at least >= 5.7.0. Otherwise, users who has a lower provider version ( < 5.7.0 ) and use a pessimistic operator constraint for the module would have their code breaking. This probably might be the reason why this change was also merged into #148

added require of version to be ">= 5.8, < 6.0".