minerllabs / minerl

MineRL Competition for Sample Efficient Reinforcement Learning - Python Package
http://minerl.io/docs/
Other
703 stars 155 forks source link

Glaring, impactful bug #51

Closed albertwujj closed 5 years ago

albertwujj commented 5 years ago

Using the following script on Ubuntu 18.04 breaks:

import minerl
data = minerl.data.make('MineRLNavigateExtremeDense-v0')
pov_shape = (64,64,3)

for obs, rew, done, act in data.seq_iter(num_epochs=1, max_sequence_len=32):
    for x in obs['pov']:
        if x.shape != pov_shape:
            print(f'mineRL bug, pov shape: {x.shape}')
albertwujj commented 5 years ago

May you please respond? The observation shape for 'pov' should clearly be (64, 64, 3), but if you run the above you'll see (at least on my computer), that it is sometimes (64 times 3, 64 times 4, 3).

MadcowD commented 5 years ago

@brandonhoughton Can you please address this. Even if you make a hotpatch for the data sequence iterator to ensure the correct data is drawn; we need to fix this.

@albertwujj Oni t!

MadcowD commented 5 years ago

Duplicate of #28 Fix completed, will be released in the next minerl update.