search

minerllabs / minerl

MineRL Competition for Sample Efficient Reinforcement Learning - Python Package
http://minerl.io/docs/
Other
711 stars 153 forks source link

Remove hardcoded xvfb #556

Closed Miffyli closed 3 years ago

Miffyli commented 3 years ago

Remove hardcoded xvfb use on Linux, which can speed up MineRL by 2-3x on headed, GPU machines. Also update docs to reflect the new behaviour (e.g. the Minecraft window does not update while agent plays).

You can also use MINERL_HEADLESS=1 to do headless runs (adds xvfb automatically).

Miffyli commented 3 years ago

Are the CI/build errors something related to these changes or random derp? I can not see the logs. Maybe CI requires adding the MINERL_HEADLESS thing? Locally docs and MineRL works fine.

brandonhoughton commented 3 years ago

ERROR: /var/lib/buildkite-agent/builds/buildkite-root-20210629101407-19-1/openai-mono/minerl-public-dev/pytest.ini:11: duplicate name 'setenv'

Miffyli commented 3 years ago

Gah, it would be nice to fix the errors if it is related to the headless-ness. Was it the pytest config again? :')

shwang commented 3 years ago

We can probably get CircleCI (i.e. public testing failure logs) up for tests that don't launch Minecraft soon.

(The current tests that launch Minecraft are flakey anyways, because BASALT envs (maybe even all environments) have some random spawn deaths for some reason)

Miffyli commented 3 years ago

Gotcha, I am going to merge this as this feature would be very desirable for v0.4.1, and it passes locally.